]> gitweb.fluxo.info Git - puppet-stdlib.git/commit
fqdn_rotate: Don't use the value itself as part of the random seed
authorEli Young <elyscape@gmail.com>
Fri, 29 May 2015 01:15:05 +0000 (18:15 -0700)
committerEli Young <elyscape@gmail.com>
Mon, 1 Jun 2015 23:19:07 +0000 (16:19 -0700)
commit601f681787c8d6c02bb3566b8cefde289377be0e
tree1f6ce54256909aafc643bf89ee2b203a58e70d80
parenta383705fdb133978e53503b7e01012367fac139d
fqdn_rotate: Don't use the value itself as part of the random seed

Previously, the random number generator was seeded with the array or
string to be rotated in addition to any values specifically provided for
seeding. This behavior is potentially insecure in that it allows an
attacker who can modify the source data to choose the post-shuffle
order.
lib/puppet/parser/functions/fqdn_rotate.rb
spec/acceptance/fqdn_rotate_spec.rb
spec/functions/fqdn_rotate_spec.rb