jslinted ui.widgets.js

git-svn-id: http://code.elgg.org/elgg/trunk@7264 36083f99-b078-4883-b0ff-0f9b5a30f544

diff --git a/js/lib/ui.widgets.js b/js/lib/ui.widgets.js
index 1e3163709ee6116f583a9d487703606cd307d82d..bce5aea0f65add72feda2f20dc996695aebdec79 100644 (file)
--- a/js/lib/ui.widgets.js
+++ b/js/lib/ui.widgets.js
@@ -24,13 +24,13 @@ elgg.ui.widgets.init = function() {
                opacity: 0.9,\r
                appendTo: 'body',\r
                connectWith: els,\r
-               stop: function(e,ui) {\r
+               stop: function(e, ui) {\r
                        // refresh list before updating hidden fields with new widget order\r
                        $(this).sortable("refresh");\r
 \r
-                       var widgetNamesLeft = outputWidgetList('#leftcolumn_widgets');\r
-                       var widgetNamesMiddle = outputWidgetList('#middlecolumn_widgets');\r
-                       var widgetNamesRight = outputWidgetList('#rightcolumn_widgets');\r
+                       var widgetNamesLeft = elgg.ui.widgets.outputList('#leftcolumn_widgets'),\r
+                               widgetNamesMiddle = elgg.ui.widgets.outputList('#middlecolumn_widgets'),\r
+                               widgetNamesRight = elgg.ui.widgets.outputList('#rightcolumn_widgets');\r
 \r
                        $('#debugField1').val(widgetNamesLeft);\r
                        $('#debugField2').val(widgetNamesMiddle);\r
@@ -44,15 +44,14 @@ elgg.ui.widgets.init = function() {
 \r
 //List active widgets for each page column\r
 elgg.ui.widgets.outputList = function(forElement) {\r
-       return( $("input[name='handler'], input[name='guid']", forElement ).makeDelimitedList("value") );\r
+       return $("input[name='handler'], input[name='guid']", forElement).makeDelimitedList("value");\r
 };\r
 \r
 //Read each widgets collapsed/expanded state from cookie and apply\r
 elgg.ui.widgets.state = function(forWidget) {\r
-\r
        var thisWidgetState = elgg.session.cookie(forWidget);\r
 \r
-       if (thisWidgetState == 'collapsed') {\r
+       if (thisWidgetState === 'collapsed') {\r
                forWidget = "#" + forWidget;\r
                $(forWidget).find("div.collapsable_box_content").hide();\r
                $(forWidget).find("a.toggle_box_contents").html('+');\r
@@ -64,17 +63,17 @@ elgg.ui.widgets.state = function(forWidget) {
 elgg.ui.widgets.moreinfo = function() {\r
        $("img.more_info").hover(function(e) {\r
                var widgetdescription = $("input[name='description']", this.parentNode.parentNode.parentNode).val();\r
-               $("body").append("<p id='widget_moreinfo'><b>"+ widgetdescription +" </b></p>");\r
+               $("body").append("<p id='widget_moreinfo'><b>" + widgetdescription + " </b></p>");\r
 \r
                if (e.pageX < 900) {\r
                        $("#widget_moreinfo")\r
-                               .css("top",(e.pageY + 10) + "px")\r
-                               .css("left",(e.pageX + 10) + "px")\r
+                               .css("top", (e.pageY + 10) + "px")\r
+                               .css("left", (e.pageX + 10) + "px")\r
                                .fadeIn("medium");\r
                } else {\r
                        $("#widget_moreinfo")\r
-                               .css("top",(e.pageY + 10) + "px")\r
-                               .css("left",(e.pageX - 210) + "px")\r
+                               .css("top", (e.pageY + 10) + "px")\r
+                               .css("left", (e.pageX - 210) + "px")\r
                                .fadeIn("medium");\r
                }\r
        }, function() {\r
@@ -84,15 +83,17 @@ elgg.ui.widgets.moreinfo = function() {
 \r
 //Toggle widgets contents and save to a cookie\r
 elgg.ui.widgets.toggleContent = function(e) {\r
-       var targetContent = $('div.collapsable_box_content', this.parentNode.parentNode);\r
-       if (targetContent.css('display') == 'none') {\r
+       var thisWidgetName,\r
+               targetContent = $('div.collapsable_box_content', this.parentNode.parentNode);\r
+       \r
+       if (targetContent.css('display') === 'none') {\r
                targetContent.slideDown(400);\r
                $(this).html('-');\r
                $(this.parentNode).children(".toggle_box_edit_panel").fadeIn('medium');\r
 \r
                // set cookie for widget panel open-state\r
-               var thisWidgetName = $(this.parentNode.parentNode.parentNode).attr('id');\r
-               $.cookie(thisWidgetName, 'expanded', { expires: 365 });\r
+               thisWidgetName = $(this.parentNode.parentNode.parentNode).attr('id');\r
+               elgg.session.cookie(thisWidgetName, 'expanded', {expires: 365 });\r
 \r
        } else {\r
                targetContent.slideUp(400);\r
@@ -102,8 +103,8 @@ elgg.ui.widgets.toggleContent = function(e) {
                $(this.parentNode.parentNode).children(".collapsable_box_editpanel").hide();\r
 \r
                // set cookie for widget panel closed-state\r
-               var thisWidgetName = $(this.parentNode.parentNode.parentNode).attr('id');\r
-               $.cookie(thisWidgetName, 'collapsed', { expires: 365 });\r
+               thisWidgetName = $(this.parentNode.parentNode.parentNode).attr('id');\r
+               elgg.session.cookie(thisWidgetName, 'collapsed', { expires: 365 });\r
        }\r
        return false;\r
 };\r