Fixes #3710. Returning false from update, <type> event no longer deletes entity.

Returning false from create, <type> still deletes the entity because of the "return false to halt events" approach. This will be reviewed for #3784.

diff --git a/engine/lib/objects.php b/engine/lib/objects.php
index 63d0f5cef1f0a27f4062e8832bf10fa52ffee70d..f186c66cb1105073d2215af240264d0bbac15b13 100644 (file)
--- a/engine/lib/objects.php
+++ b/engine/lib/objects.php
@@ -52,11 +52,8 @@ function create_object_entity($guid, $title, $description) {
                        if ($result != false) {
                                // Update succeeded, continue
                                $entity = get_entity($guid);
-                               if (elgg_trigger_event('update', $entity->type, $entity)) {
-                                       return $guid;
-                               } else {
-                                       $entity->delete();
-                               }
+                               elgg_trigger_event('update', $entity->type, $entity);
+                               return $guid;
                        }
                } else {
                        // Update failed, attempt an insert.