Fix: spice clients support

diff --git a/IDEAS.md b/IDEAS.md
index 471f9c906175c4cfb8e9a3c9c6f92d02be2c4f44..7bb6e90454ab75993bb2a53b707cd6f94d46062f 100644 (file)
--- a/IDEAS.md
+++ b/IDEAS.md
@@ -12,6 +12,8 @@
 
 * Shell completions.
 
+* Support for other Spice clients such as [Remmina](https://remmina.org).
+
 * Support for multiple source/targets pairs (analogous to `shared_folders`) at:
   * `provision_rsync`
 

diff --git a/kvmx b/kvmx
index fb0faecbc98ed534d664d9ab213fb15d4f7de2e6..1ca55e11aa94b7174ceddacc76e243ad14dcf622 100755 (executable)
--- a/kvmx
+++ b/kvmx
@@ -257,10 +257,17 @@ function kvmx_spice {
   if [ "$spice_client" == "spicy" ] && which spicy &> /dev/null; then
     #spicy -h localhost -p $PORT &
     spicy --uri=spice+unix://$SPICESOCKET &
-  elif [ "$spice_client" == "virt-viewer" ] && which virt-viewer &> /dev/null; then
+  elif [ "$spice_client" == "remote-viewer" ] && which remote-viewer &> /dev/null; then
     #remote-viewer spice://localhost:$PORT &
     remote-viewer spice+unix://$SPICESOCKET &
-  #elif [ ! -z "$spice_client" ] && [ "$spice_client" != "spicec" ]; then
+  # This is untested due to libvirt requirements
+  elif [ "$spice_client" == "virt-viewer" ] && which virt-viewer &> /dev/null; then
+    #virt-viewer spice://localhost:$PORT &
+    virt-viewer spice+unix://$SPICESOCKET &
+  # Unsupported as spicec was deprecated
+  #elif [ "$spice_client" != "spicec" ] && which spicec &> /dev/null; then
+  #  # https://lists.freedesktop.org/archives/spice-devel/2013-September/014643.html
+  #  SPICE_NOGRAB=1 spicec --host localhost --port $PORT &> $SPICELOG &
   elif [ ! -z "$spice_client" ]; then
     echo "$BASENAME: spice_client $spice_client not currently supported"
     exit 1
@@ -269,11 +276,6 @@ function kvmx_spice {
       #spicy -h localhost -p $PORT &
       spicy --uri=spice+unix://$SPICESOCKET &
     fi
-
-    #if which spicec &> /dev/null; then
-    #  # https://lists.freedesktop.org/archives/spice-devel/2013-September/014643.html
-    #  SPICE_NOGRAB=1 spicec --host localhost --port $PORT &> $SPICELOG &
-    #fi
   fi
 
   SPICEPID="$!"

diff --git a/kvmxfile b/kvmxfile
index d51797286513bfc357e9d37035f6f2dadea69a87..8d7246c61ba31ea916ff7e7b31a403d778a8d6a1 100644 (file)
--- a/kvmxfile
+++ b/kvmxfile
@@ -105,7 +105,7 @@ spice="1"
 run_spice_client="1"
 
 # SPICE client
-#spice_client="spicec"
+#spice_client="remote-viewer"
 #spice_client="virt-viewer"
 spice_client="spicy"