re-implement guest account on the share level

diff --git a/manifests/server/share.pp b/manifests/server/share.pp
index 86cbb13a0fa9c6b32c627eefcabee24f0283c9a1..5544caffca79e8d05b986cf7175e5f347128f6e7 100644 (file)
--- a/manifests/server/share.pp
+++ b/manifests/server/share.pp
@@ -39,6 +39,7 @@ define samba::server::share($ensure = present,
                             $delete_readonly = '',
                             $printer_name = '',
                             $msdfs_root = '',
+                            $guest_account = '',
                             ) {
 
   $incl    = $samba::server::incl
@@ -234,6 +235,10 @@ define samba::server::share($ensure = present,
         false   => "set \"${target}/msdfs root\" no",
         default => "rm  \"${target}/msdfs root\"",
       },
+      $guest_account ? {
+        ''      => "rm  \"${target}/guest account\"",
+        default => "set \"${target}/guest account\" '${guest_account}'",
+      },
     ]
 
     augeas { "${name}-changes":

diff --git a/spec/defines/samba__server__share_spec.rb b/spec/defines/samba__server__share_spec.rb
index 7e1c8a06838a6a16a9719e3131fba13a0a6db952..894f334ddca67615c01a0839ad6e1f88011b4d75 100644 (file)
--- a/spec/defines/samba__server__share_spec.rb
+++ b/spec/defines/samba__server__share_spec.rb
@@ -43,6 +43,7 @@ shared_examples "default share" do
     set.with("delete readonly")
     set.with("printer name")
     set.with("msdfs root")
+    set.with("guest account")
   end
   let(:change_set) { default_changes }
   let(:changes) { change_set.to_a }
@@ -672,6 +673,15 @@ describe 'samba::server::share', :type => :define do
         }}
         let(:change_set) { default_changes.with("msdfs root", "no") }
       end
+
+      context 'with guest_account set to "killing trees"' do
+        include_examples "default share"
+        let(:params) {{
+          :ensure       => 'present',
+          :guest_account => 'someone',
+        }}
+        let(:change_set) { default_changes.with("guest account", "'someone'") }
+      end
     end
   end
 end