Moved to unless from if not to improve code clarity. Added TODO

for future reference.  Changed wording of few error messages.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>

diff --git a/num2bool.rb b/num2bool.rb
index 0e6b7a5e1b305fabdc4949968eafd9c6925e0b68..2baef62778389141e13e7613fcc92986ac89334d 100644 (file)
--- a/num2bool.rb
+++ b/num2bool.rb
@@ -2,6 +2,8 @@
 # num2bool.rb
 #
 
+# TODO(Krzysztof Wilczynski): We probably need to approach numeric values differently ...
+
 module Puppet::Parser::Functions
   newfunction(:num2bool, :type => :rvalue, :doc => <<-EOS
     EOS
@@ -13,20 +15,20 @@ module Puppet::Parser::Functions
     number = arguments[0]
 
     # Only numbers allowed ...
-    if not number.match(/^\-?\d+$/)
-      raise(Puppet::ParseError, 'num2bool(): Requires a number to work with')
+    unless number.match(/^\-?\d+$/)
+      raise(Puppet::ParseError, 'num2bool(): Requires integer to work with')
     end
 
     result = case number
       when /^0$/
         false
       when /^\-?\d+$/
-        # In Puppet numbers are often string-encoded ...
+        # Numbers in Puppet are often string-encoded which is troublesome ...
         number = number.to_i
         # We yield true for any positive number and false otherwise ...
         number > 0 ? true : false
       else
-        raise(Puppet::ParseError, 'num2bool(): Unknown number format given')
+        raise(Puppet::ParseError, 'num2bool(): Unknown numeric format given')
     end
 
     return result