linting according to puppet-lint

diff --git a/manifests/base.pp b/manifests/base.pp
index 66d3477e04e69dcb8f53f05339ed2aff602b5a86..07f454166baf861ed6f4666c8236322da51d1b1f 100644 (file)
--- a/manifests/base.pp
+++ b/manifests/base.pp
@@ -1,3 +1,7 @@
+# main class to manage things
+# empty so we don't harm
+# any non supported linux
+# systems
 class loginrecords::base {
 
 }

diff --git a/manifests/btmp/disable.pp b/manifests/btmp/disable.pp
index f32d36a3a86a86c72d83c47b3a03979104f7fe31..77c5d1ef005598aafe7a9b862e17d46ea5398d35 100644 (file)
--- a/manifests/btmp/disable.pp
+++ b/manifests/btmp/disable.pp
@@ -1,5 +1,6 @@
+# ensure that btmp is not on the system
 class loginrecords::btmp::disable inherits loginrecords::btmp::enable {
-  File[$btmp_file]{
+  File[$loginrecords::btmp::enable::btmp_file]{
     ensure => 'absent',
     backup => false,
   }

diff --git a/manifests/btmp/enable.pp b/manifests/btmp/enable.pp
index c173362740156d578f633445cccd6c18b1f651b6..95c663d07b3922b03e937a01ae2ab8fe4748326a 100644 (file)
--- a/manifests/btmp/enable.pp
+++ b/manifests/btmp/enable.pp
@@ -1,8 +1,11 @@
+# manage the btmp file
 class loginrecords::btmp::enable(
   $btmp_file = '/var/log/btmp'
 ){
-  file{$btmp_file:
-    ensure => 'present',
-    owner => 'root', group => 'utmp', mode => 660;
+  file{$loginrecords::btmp::enable::btmp_file:
+    ensure  => 'present',
+    owner   => 'root',
+    group   => 'utmp',
+    mode    => '0660';
   }
 }

diff --git a/manifests/debian.pp b/manifests/debian.pp
index e68185b63f7f5f96b169259c5f8208cc1cfabe4a..0813d2f6b8a95880ade56bb6aa68a695e5623d7a 100644 (file)
--- a/manifests/debian.pp
+++ b/manifests/debian.pp
@@ -1,3 +1,4 @@
+# how loginrecords are managed on debian
 class loginrecords::debian inherits loginrecords::base {
 
   if $loginrecords::disable_btmp {

diff --git a/manifests/faillog/disable.pp b/manifests/faillog/disable.pp
index c05e6bc8797f1107a9d9c18fd00e612fc52da5c6..4e1df4edefbc6f1ddff9a9ba4376db206769204d 100644 (file)
--- a/manifests/faillog/disable.pp
+++ b/manifests/faillog/disable.pp
@@ -1,9 +1,10 @@
+# do not log any faillog
 class loginrecords::faillog::disable inherits loginrecords::faillog::enable{
   Replace['loginrecords-faillog']{
-    pattern   => '^FAILLOG_ENAB[[:space:]]+yes$',
-    replacement => 'FAILLOG_ENAB               no',
+    pattern     => '^FAILLOG_ENAB[[:space:]]+yes$',
+    replacement => "FAILLOG_ENAB\tno",
   }
   Line['loginrecords-faillog']{
-    line  => 'FAILLOG_ENAB             no',
+    line  => "FAILLOG_ENAB\tno",
   }
 }

diff --git a/manifests/faillog/enable.pp b/manifests/faillog/enable.pp
index c714b74e8139e78ef136eb35d206f27c374971c1..d600f6f4796e03127022e68e5c9d28907208ebe5 100644 (file)
--- a/manifests/faillog/enable.pp
+++ b/manifests/faillog/enable.pp
@@ -1,14 +1,15 @@
+# manage faillog logging
 class loginrecords::faillog::enable(
   $login_defs_file = '/etc/login.defs'
 ) {
   replace{'loginrecords-faillog':
-    file    => $login_defs_file,
-    pattern   => '^FAILLOG_ENAB[[:space]]+no$',
-    replacement => 'FAILLOG_ENAB               yes',
+    file        => $loginrecords::faillog::enable::login_defs_file,
+    pattern     => '^FAILLOG_ENAB[[:space]]+no$',
+    replacement => "FAILLOG_ENAB\tyes",
   }
   line{'loginrecords-faillog':
-    file  => $login_defs_file,
-    line  => 'FAILLOG_ENAB             yes',
+    file    => $loginrecords::faillog::enable::login_defs_file,
+    line    => "FAILLOG_ENAB\tyes",
     require => Replace['loginrecords-faillog'],
   }
 }

diff --git a/manifests/init.pp b/manifests/init.pp
index 5c9f80053dafb37d51f54c7cc8ddff913a4c8f3b..dd0e48eba3b95685668802b189c21012d14e0dd7 100644 (file)
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -1,17 +1,19 @@
+# manage how login records are
+# stored on the system
 class loginrecords(
-  $disable_btmp = true,
-  $disable_faillog = true,
-  $disable_lastlog = true,
-  $protect_utmp = true,
-  $disable_wtmp = true,
+  $disable_btmp       = true,
+  $disable_faillog    = true,
+  $disable_lastlog    = true,
+  $protect_utmp       = true,
+  $disable_wtmp       = true,
   $ramdisk_on_var_run = true
 ){
   # Include main class
   case $::kernel {
-    "Linux": {
-      case  $::operatingsystem {
-        "debian", "ubuntu": { include loginrecords::debian }
-        default:            { include loginrecords::base   }
+    Linux: {
+      case $::operatingsystem {
+        debian, ubuntu: { include loginrecords::debian }
+        default:        { include loginrecords::base }
       }
     }
     default: {

diff --git a/manifests/lastlog/disable.pp b/manifests/lastlog/disable.pp
index 69e13d5db43b60a6ff1c953ad832ebb743b94740..f97c49c73edca6a432e2ca05bde53363bddc0313 100644 (file)
--- a/manifests/lastlog/disable.pp
+++ b/manifests/lastlog/disable.pp
@@ -1,6 +1,7 @@
+# disable lastlog loggin of pam
 class loginrecords::lastlog::disable inherits loginrecords::lastlog::enable {
   Replace['loginrecords-lastlog']{
-    pattern   => '^session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
+    pattern     => '^session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
     replacement => '#session  optional   pam_lastlog.so',
   }
   File['/var/log/lastlog']{

diff --git a/manifests/lastlog/enable.pp b/manifests/lastlog/enable.pp
index bd9378b5e484496ce82c4acce039d55dc2836c08..b8dec35e160c59bad8433d3cbdbb6a647773b79f 100644 (file)
--- a/manifests/lastlog/enable.pp
+++ b/manifests/lastlog/enable.pp
@@ -1,13 +1,16 @@
+# manage the lastlog logging of pam
 class loginrecords::lastlog::enable(
   $pam_login_file = '/etc/pam.d/login'
 ){
   replace{'loginrecords-lastlog':
-    file => $pam_login_file,
-    pattern   => '^#session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
+    file        => $pam_login_file,
+    pattern     => '^#session[[:space:]]+optional[[:space:]]+pam_lastlog.so$',
     replacement => 'session  optional   pam_lastlog.so',
   }
   file{'/var/log/lastlog':
-    ensure => present,
-    owner => root, group => utmp, mode => 0664;
+    ensure  => present,
+    owner   => 'root',
+    group   => 'utmp',
+    mode    => '0664';
   }
 }

diff --git a/manifests/ramrun/disable.pp b/manifests/ramrun/disable.pp
index 3d282a3544e907491726db1c7f630a9a5b639b26..d745bf0d1f1690aa3526a690ddaae5127bf24c29 100644 (file)
--- a/manifests/ramrun/disable.pp
+++ b/manifests/ramrun/disable.pp
@@ -1,7 +1,6 @@
+# do not put /var/run on a ramdisk
 class loginrecords::ramrun::disable inherits loginrecords::ramrun::enable {
-
-  Augeas["ramdisk-on-var-run"]{
-    changes => "set RAMRUN yes",
+  Augeas['ramdisk-on-var-run']{
+    changes => 'set RAMRUN yes',
   }
-
 }

diff --git a/manifests/ramrun/enable.pp b/manifests/ramrun/enable.pp
index 564ef06a648520e6e664406806b2b3d42782ebba..27bf40919cc34dfe66a8f93e66ca7fc182a1a3b4 100644 (file)
--- a/manifests/ramrun/enable.pp
+++ b/manifests/ramrun/enable.pp
@@ -1,8 +1,7 @@
+# put /var/run on a ramdisk?
 class loginrecords::ramrun::enable {
-
-  augeas { "ramdisk-on-var-run":
-    context => "/files/etc/default/rcS",
-    changes => "set RAMRUN yes",
+  augeas{'ramdisk-on-var-run':
+    context => '/files/etc/default/rcS',
+    changes => 'set RAMRUN yes',
   }
-
 }

diff --git a/manifests/utmp/protect.pp b/manifests/utmp/protect.pp
index 166df5e9395aea503db146ed161301d25f16e671..603064e8a8d3296a4fba2451138a89bcf3c51ea2 100644 (file)
--- a/manifests/utmp/protect.pp
+++ b/manifests/utmp/protect.pp
@@ -1,5 +1,6 @@
+# make the unprotect file protected from global read
 class loginrecords::utmp::protect inherits loginrecords::utmp::unprotect {
-  File[$utmp_file]{
+  File[$loginrecords::utmp::protect::utmp_file]{
     mode => 660,
   }
 }

diff --git a/manifests/utmp/unprotect.pp b/manifests/utmp/unprotect.pp
index 9da751705590d736eaaafcabd62fdfee90727620..54d821b30fda12579ac76e66838845f6a0279a29 100644 (file)
--- a/manifests/utmp/unprotect.pp
+++ b/manifests/utmp/unprotect.pp
@@ -1,8 +1,11 @@
+# manage the utmp file
 class loginrecords::utmp::unprotect(
   $utmp_file = '/var/run/utmp'
 ){
-  file{$utmp_file:
-    ensure => 'present',
-    owner => 'root', group => 'utmp', mode => 664;
+  file{$loginrecords::utmp::unprotect::utmp_file:
+    ensure  => 'present',
+    owner   => 'root',
+    group   => 'utmp',
+    mode    => '0664';
   }
 }

diff --git a/manifests/wtmp/disable.pp b/manifests/wtmp/disable.pp
index 0d53e577fce6fe267961df11b8e41c416a6e3a32..f98e201682b69e37324d88fb548f7820cb3e807b 100644 (file)
--- a/manifests/wtmp/disable.pp
+++ b/manifests/wtmp/disable.pp
@@ -1,5 +1,6 @@
+# ensure that wtmp is not on the system
 class loginrecords::wtmp::disable inherits loginrecords::wtmp::enable {
-  File[$wtmp_file]{
+  File[$loginrecords::wtmp::enable::wtmp_file]{
     ensure => 'absent',
     backup => false,
   }

diff --git a/manifests/wtmp/enable.pp b/manifests/wtmp/enable.pp
index f3b5ee996fa678a98b9680f4d75fc91120e5bb37..4ba57ee97beeae4b3417c61e51c7b686784b009c 100644 (file)
--- a/manifests/wtmp/enable.pp
+++ b/manifests/wtmp/enable.pp
@@ -1,8 +1,11 @@
+# manage wtmp
 class loginrecords::wtmp::enable(
   $wtmp_file = '/var/log/wtmp'
 ){
-  file{$wtmp_file:
-    ensure => 'present',
-    owner => 'root', group => 'utmp', mode => 664;
+  file{$loginrecords::wtmp::enable::wtmp_file:
+    ensure  => 'present',
+    owner   => 'root',
+    group   => 'utmp',
+    mode    => '0664';
   }
 }