Make numericids defaults to null (fixes #3691)

diff --git a/ChangeLog b/ChangeLog
index dd7418ae63f81a09f19d55db60523806de7e0f15..e1ac76d485a5a7e9e2b56a1ff11b1b89d72206c7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 version 1.0 -- UNRELEASED
     handler changes
+       rysnc:
+        . Fix numericids option (Redmine#3691).
        dup:
         . Make the .dup generated by ninjahelper more consistent with
           example.dup.

diff --git a/handlers/rsync.in b/handlers/rsync.in
index 6c772e111e9923c4fea08d127cd257e805fa96b6..cc255a3e6b93cdc1665f65b131ff2e5e910fb2ec 100644 (file)
--- a/handlers/rsync.in
+++ b/handlers/rsync.in
@@ -887,7 +887,7 @@ function set_filelist {
 
 function set_rsync_options {
 
-  if [ ! -z "$numericids" ]; then
+  if [ "$numericids" != "0" ]; then
     rsync_options="$rsync_options --numeric-ids"
   fi