]> gitweb.fluxo.info Git - puppet-stdlib.git/commitdiff
(#8792) Rename whole_line type to file_line
authorJeff McCune <jeff@puppetlabs.com>
Fri, 5 Aug 2011 02:17:48 +0000 (19:17 -0700)
committerJeff McCune <jeff@puppetlabs.com>
Fri, 5 Aug 2011 02:17:48 +0000 (19:17 -0700)
Without this patch the resource whole_line would be included in the
stable stdlib module shipping in PE 1.2.  Ideally the name will be
stable and unchanging in the future.

There was quite a bit of concern over whole_line being an unwise name.
file_line appears to be the most suitable name and least likely to need
another rename in the future.

lib/puppet/provider/file_line/ruby.rb [moved from lib/puppet/provider/whole_line/ruby.rb with 82% similarity]
lib/puppet/type/file_line.rb [moved from lib/puppet/type/whole_line.rb with 93% similarity]
spec/unit/puppet/provider/file_line/ruby_spec.rb [moved from spec/unit/puppet/provider/whole_line/ruby_spec.rb with 87% similarity]
spec/unit/puppet/type/file_line_spec.rb [new file with mode: 0644]
spec/unit/puppet/type/whole_line_spec.rb [deleted file]

similarity index 82%
rename from lib/puppet/provider/whole_line/ruby.rb
rename to lib/puppet/provider/file_line/ruby.rb
index 156f2559de876047ad26f5046045a8ed3895ff75..63bbd8e819b9c125b717d78ad2e12cc4c51a5d95 100644 (file)
@@ -1,4 +1,4 @@
-Puppet::Type.type(:whole_line).provide(:ruby) do
+Puppet::Type.type(:file_line).provide(:ruby) do
 
   def exists?
     File.readlines(resource[:path]).find do |line|
similarity index 93%
rename from lib/puppet/type/whole_line.rb
rename to lib/puppet/type/file_line.rb
index f231602f4a6e9d3ddfccfb5757e53de91be1d249..aacd6d9866f2c048c0895dc395ed82656a1a6763 100644 (file)
@@ -1,11 +1,11 @@
-Puppet::Type.newtype(:whole_line) do
+Puppet::Type.newtype(:file_line) do
 
   desc <<-EOT
   Type that can append whole a line to a file if it does not already contain it.
 
   Example:
 
-  whole_line { 'sudo_rule':
+  file_line { 'sudo_rule':
     path => '/etc/sudoers',
     line => '%admin ALL=(ALL) ALL',
   }
similarity index 87%
rename from spec/unit/puppet/provider/whole_line/ruby_spec.rb
rename to spec/unit/puppet/provider/file_line/ruby_spec.rb
index 9faff2c4cb5d6886ec4db2854c40ec8d5f52547e..b03fc0ea9787398ecb6845f44b7538d375b3be51 100644 (file)
@@ -1,12 +1,12 @@
 require 'puppet'
 require 'tempfile'
-provider_class = Puppet::Type.type(:whole_line).provider(:ruby)
+provider_class = Puppet::Type.type(:file_line).provider(:ruby)
 describe provider_class do
   before :each do
     tmp = Tempfile.new('tmp')
     @tmpfile = tmp.path
     tmp.close!
-    @resource = Puppet::Type::Whole_line.new(
+    @resource = Puppet::Type::File_line.new(
       {:name => 'foo', :path => @tmpfile, :line => 'foo'}
     )
     @provider = provider_class.new(@resource)
diff --git a/spec/unit/puppet/type/file_line_spec.rb b/spec/unit/puppet/type/file_line_spec.rb
new file mode 100644 (file)
index 0000000..7e07c06
--- /dev/null
@@ -0,0 +1,24 @@
+require 'puppet'
+require 'tempfile'
+describe Puppet::Type.type(:file_line) do
+  before :each do
+    @file_line = Puppet::Type.type(:file_line).new(:name => 'foo', :line => 'line', :path => '/tmp/path')
+  end
+  it 'should accept a line and path' do
+    @file_line[:line] = 'my_line'
+    @file_line[:line].should == 'my_line'
+  end
+  it 'should accept posix filenames' do
+    @file_line[:path] = '/tmp/path'
+    @file_line[:path].should == '/tmp/path'
+  end
+  it 'should not accept unqualified path' do
+    expect { @file_line[:path] = 'file' }.should raise_error(Puppet::Error, /File paths must be fully qualified/)
+  end
+  it 'should require that a line is specified' do
+    expect { Puppet::Type.type(:file_line).new(:name => 'foo', :path => '/tmp/file') }.should raise_error(Puppet::Error, /Both line and path are required attributes/)
+  end
+  it 'should require that a file is specified' do
+    expect { Puppet::Type.type(:file_line).new(:name => 'foo', :line => 'path') }.should raise_error(Puppet::Error, /Both line and path are required attributes/)
+  end
+end
diff --git a/spec/unit/puppet/type/whole_line_spec.rb b/spec/unit/puppet/type/whole_line_spec.rb
deleted file mode 100644 (file)
index f273baa..0000000
+++ /dev/null
@@ -1,24 +0,0 @@
-require 'puppet'
-require 'tempfile'
-describe Puppet::Type.type(:whole_line) do
-  before :each do
-    @whole_line = Puppet::Type.type(:whole_line).new(:name => 'foo', :line => 'line', :path => '/tmp/path')
-  end
-  it 'should accept a line and path' do
-    @whole_line[:line] = 'my_line'
-    @whole_line[:line].should == 'my_line'
-  end
-  it 'should accept posix filenames' do
-    @whole_line[:path] = '/tmp/path'
-    @whole_line[:path].should == '/tmp/path'
-  end
-  it 'should not accept unqualified path' do
-    expect { @whole_line[:path] = 'file' }.should raise_error(Puppet::Error, /File paths must be fully qualified/)
-  end
-  it 'should require that a line is specified' do
-    expect { Puppet::Type.type(:whole_line).new(:name => 'foo', :path => '/tmp/file') }.should raise_error(Puppet::Error, /Both line and path are required attributes/)
-  end
-  it 'should require that a file is specified' do
-    expect { Puppet::Type.type(:whole_line).new(:name => 'foo', :line => 'path') }.should raise_error(Puppet::Error, /Both line and path are required attributes/)
-  end
-end