]> gitweb.fluxo.info Git - lorea/elgg.git/commitdiff
Using nullFunction + abstractMethod reference instead of new closures in EventsTest
authorewinslow <ewinslow@36083f99-b078-4883-b0ff-0f9b5a30f544>
Tue, 9 Nov 2010 00:56:48 +0000 (00:56 +0000)
committerewinslow <ewinslow@36083f99-b078-4883-b0ff-0f9b5a30f544>
Tue, 9 Nov 2010 00:56:48 +0000 (00:56 +0000)
git-svn-id: http://code.elgg.org/elgg/trunk@7266 36083f99-b078-4883-b0ff-0f9b5a30f544

js/tests/ElggEventsTest.js

index cc30e841861447c6372fa57839763f18656ceb85..1fc9c8e868461239e90173d40d0f63f1401b01a2 100644 (file)
@@ -5,24 +5,24 @@ ElggEventsTest.prototype.setUp = function() {
        elgg.provide('elgg.config.events.all.all');
 };
 
-ElggEventsTest.prototype.testEventHandlersMustBeFunctions = function() {
+ElggEventsTest.prototype.testEventHandlersMustBeFunctions = function () {
        assertException(function() { elgg.register_event_handler('str', 'str', 'oops'); });
 };
 
-ElggEventsTest.prototype.testReturnValueDefaultsToTrue = function() {
+ElggEventsTest.prototype.testReturnValueDefaultsToTrue = function () {
        assertTrue(elgg.trigger_event('fee', 'fum'));
        
-       elgg.register_event_handler('fee', 'fum', function() {});
+       elgg.register_event_handler('fee', 'fum', elgg.nullFunction);
        assertTrue(elgg.trigger_event('fee', 'fum'));
 };
 
-ElggEventsTest.prototype.testCanGlomEventsWithAll = function() {
-       elgg.register_event_handler('all', 'bar', function() { throw new Error(); });
+ElggEventsTest.prototype.testCanGlomEventsWithAll = function () {
+       elgg.register_event_handler('all', 'bar', elgg.abstractMethod);
        assertException("all,bar", function() { elgg.trigger_event('foo', 'bar'); });
        
-       elgg.register_event_handler('foo', 'all', function() { throw new Error(); });
+       elgg.register_event_handler('foo', 'all', elgg.abstractMethod);
        assertException("foo,all", function() { elgg.trigger_event('foo', 'baz'); });
        
-       elgg.register_event_handler('all', 'all', function() { throw new Error(); });   
+       elgg.register_event_handler('all', 'all', elgg.abstractMethod); 
        assertException("all,all", function() { elgg.trigger_event('pinky', 'winky'); });
 };
\ No newline at end of file