Fixes #3741 fixed menu code so that all links do not get empty title and confirm...

diff --git a/engine/classes/ElggMenuItem.php b/engine/classes/ElggMenuItem.php
index cfdc2f5fa2bd1be6bd8aabfcdaeb5b4b5dde5bc2..f7a6b5c65e88b56da707dabb7f5494e1e8e43544 100644 (file)
--- a/engine/classes/ElggMenuItem.php
+++ b/engine/classes/ElggMenuItem.php
@@ -59,7 +59,7 @@ class ElggMenuItem {
        /**
         * @var string Tooltip
         */
-       protected $title = '';
+       protected $title = false;
 
        /**
         * @var string The string to display if link is clicked
@@ -552,6 +552,8 @@ class ElggMenuItem {
                if ($this->confirm) {
                        $vars['confirm'] = $this->confirm;
                        return elgg_view('output/confirmlink', $vars);
+               } else {
+                       unset($vars['confirm']);
                }
 
                return elgg_view('output/url', $vars);