refactor things for >2.7

diff --git a/manifests/base.pp b/manifests/base.pp
index 12dd9e74198311ff1a11c5ad46e8ebb5fd86da15..4b9f0355332dc995373274d3412f9579a760413e 100644 (file)
--- a/manifests/base.pp
+++ b/manifests/base.pp
@@ -4,8 +4,8 @@ class ejabberd::base {
   }
 
   file{'/etc/ejabberd/ejabberd.cfg':
-    source => [ "puppet:///modules/site-ejabberd/${fqdn}/ejabberd.cfg",
-                "puppet:///modules/site-ejabberd/ejabberd.cfg",
+    source => [ "puppet:///modules/site_ejabberd/${::fqdn}/ejabberd.cfg",
+                "puppet:///modules/site_ejabberd/ejabberd.cfg",
                 "puppet:///modules/ejabberd/ejabberd.cfg" ],
     require => Package['ejabberd'],
     notify => Service['ejabberd'],

diff --git a/manifests/init.pp b/manifests/init.pp
index d8b9d4432cc2ef3035a96271fdee3893e9724e7d..91c8e1fd76889879d7a338671627bb0309f7043c 100644 (file)
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -2,19 +2,24 @@
 # Copyright (C) 2007 admin@immerda.ch
 # GPLv3
 
-class ejabberd {
-  case $operatingsystem {
+class ejabberd(
+  $domains = $::fqdn,
+  $nagios_domain = hiera('ejabberd_nagios_domain', $::fqdn),
+  $nagios_user = hiera('ejabberd_nagios_user', 'nagios'),
+  $nagios_pwd = hiera('ejabberd_nagios_pwd','')
+) {
+  case $::operatingsystem {
     default: { include ejabberd::base }
   }
-  if $use_nagios {
+  if hiera('use_nagios',false) {
     include ejabberd::nagios
   }
 
-  if $use_munin {
+  if hiera('use_munin',false) {
     include ejabberd::munin
   }
 
-  if $use_shorewall {
+  if hiera('use_shorewall',false) {
     include shorewall::rules::jabberserver
   }
 }

diff --git a/manifests/munin.pp b/manifests/munin.pp
index 1357e98f3c3963d44201a03a3a528bffd961c4b6..61d64323a73caeb1ee71ecc6505f3e6334068168 100644 (file)
--- a/manifests/munin.pp
+++ b/manifests/munin.pp
@@ -1,14 +1,12 @@
 class ejabberd::munin {
-  case $ejabberd_domains {
-    '': { $ejabberd_domains = $fqdn }
-  }
-  munin::plugin::deploy{'ejabberd_': 
-    source => "ejabberd/munin/ejabberd_", 
+  munin::plugin::deploy{'ejabberd_':
+    source => "ejabberd/munin/ejabberd_",
     ensure => absent,
   }
+  $domains = join($ejabberd::domains, ' ')
   munin::plugin{['ejabberd_users','ejabberd_connections','ejabberd_registrations']:
     require => Munin::Plugin::Deploy['ejabberd_'],
     ensure => 'ejabberd_',
-    config => "env.vhosts ${ejabberd_domains}\ntimeout 20\nuser root\ngroup root"
+    config => "env.vhosts ${domains}\ntimeout 20\nuser root\ngroup root"
   }
 }

diff --git a/manifests/nagios.pp b/manifests/nagios.pp
index 85a7b108b921433414f76899c0e9c32eb972f300..27df3825235601d58435a23ba42a0500851f22a3 100644 (file)
--- a/manifests/nagios.pp
+++ b/manifests/nagios.pp
@@ -1,25 +1,18 @@
 # manifests/nagios.pp
 
 class ejabberd::nagios {
-  case $jabber_nagios_domain {
-    '': { $jabber_nagios_domain = $fqdn }
-  }
-  nagios::service{ "jabber_${fqdn}": check_command => "check_jabber!${jabber_nagios_domain}" }
+  nagios::service{ "jabber_${::fqdn}": check_command => "check_jabber!${ejabberd::nagios_domain}" }
   @@nagios_command{
     'check_jabber_ssl':
       command_line => '$USER1$/check_jabber -S -p 5223 -H $ARG1$',
   }
-  nagios::service{ "jabber_ssl_${fqdn}": check_command => "check_jabber_ssl!${jabber_nagios_domain}" }
+  nagios::service{ "jabber_ssl_${::fqdn}": check_command => "check_jabber_ssl!${ejabberd::nagios_domain}" }
 
   @@nagios_command{
     'check_jabber_cert':
       command_line => '$USER1$/check_jabber -S -D 10 -p 5223 -H $ARG1$',
   }
-  nagios::service{ "jabber_cert_${fqdn}": check_command => "check_jabber_cert!${jabber_nagios_domain}" }
-
-  case $jabber_nagios_user {
-    '': { $jabber_nagios_user = 'nagios' }
-  } 
+  nagios::service{ "jabber_cert_${::fqdn}": check_command => "check_jabber_cert!${ejabberd::nagios_domain}" }
 
   @@nagios_command{
     'check_jabber_login':
@@ -27,10 +20,10 @@ class ejabberd::nagios {
       require => Nagios::Plugin['check_jabber_login'];
   }
 
-  case $jabber_nagios_pwd {
-    '': { info("no \$jabber_nagios_pwd supplied for ${fqdn}! Can't test jabber login") }
-    default: { 
-      nagios::service{ "jabber_login_${fqdn}": check_command => "check_jabber_login!${jabber_nagios_user}@${jabber_nagios_domain}!${jabber_nagios_pwd}" }
+  case $ejabberd::nagios_pwd {
+    '': { info("no \$ejabberd::nagios_pwd supplied for ${::fqdn}! Can't test jabber login") }
+    default: {
+      nagios::service{ "jabber_login_${::fqdn}": check_command => "check_jabber_login!${ejabberd::nagios_user}@${ejabberd::nagios_domain}!${ejabberd::nagios_pwd}" }
     }
   }
 }