screen 4.5.0 and later expects an argument for -L

before stretch, screen took no argument for -L, and we relied on the
screenrc to indicate the name of the logfile.

in stretch, screen's -L takes an argument -- and it complains if the
argument following -L starts with a -.  This is a breaking API change
:/

so this patch can't go into versions before stretch.

diff --git a/kvm-manager b/kvm-manager
index 7af2a7233665ace59579644acb6ad479879b9535..d44de70a08a3353891d5159ae42b6aabc528c50f 100755 (executable)
--- a/kvm-manager
+++ b/kvm-manager
@@ -185,7 +185,7 @@ EOF
         -net "tap,ifname=$TAP,script=no,downscript=no,vlan=0,name=hostnet0" &
 
     chpst -u "$OWNER:$OWNERGROUP" \
-        /usr/bin/screen -D -m -L -c /etc/screenrc.kvm-manager -S "$VMNAME" -t "$VMNAME" socat STDIO,raw,echo=0 "UNIX:${CONSOLENAME},retry=30" &
+        /usr/bin/screen -D -m -L ./servicelog -c /etc/screenrc.kvm-manager -S "$VMNAME" -t "$VMNAME" socat STDIO,raw,echo=0 "UNIX:${CONSOLENAME},retry=30" &
 
     set +e
     # handle regular signals