Fix bug #3111254: getIdFromUser() always returns an integer now (part 2)

diff --git a/doc/ChangeLog b/doc/ChangeLog
index 6a08feaa7f960f7d0d2c1ff691724ea381bbf24b..a8c3e12e611af0f03b26a8f2131a2c2028225feb 100644 (file)
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -19,6 +19,7 @@ ChangeLog for SemantiScuttle
 - Fix bug #3413459: Thumbnails not in one line
 - Fix bug #3468293: Delicious import does not preserve private links
 - Fix bug #3396727: Title of http://lesscss.org/ not loaded
+- Fix bug #3111254: getIdFromUser() always returns an integer now (part 2)
 - Implement request #3403609: fr_CA translation update
 - Implement patch #3476011: PostgreSQL tables can not be initialized
   (Frédéric Fauberteau [triaxx])

diff --git a/src/SemanticScuttle/Model/User.php b/src/SemanticScuttle/Model/User.php
index 3aa617b404c1498c64ddbffae2085cd5acaadb67..e5d29af869474620a991d2c26e0d36f4db95aeef 100644 (file)
--- a/src/SemanticScuttle/Model/User.php
+++ b/src/SemanticScuttle/Model/User.php
@@ -56,7 +56,7 @@ class SemanticScuttle_Model_User
      */
     public function getId()
     {
-        return $this->id;
+        return (int)$this->id;
     }
 
     /**

diff --git a/tests/UserTest.php b/tests/UserTest.php
index 6cd67866189b5e96e4176c197433668b9ce61cef..85d22046a5bbb7adba6a462df0c7973202f9b0a5 100644 (file)
--- a/tests/UserTest.php
+++ b/tests/UserTest.php
@@ -246,6 +246,22 @@ class UserTest extends TestBase
         );
     }
 
+    public function testGetIdFromUserParamId()
+    {
+        $uid   = $this->addUser();
+        $newId = $this->us->getIdFromUser($uid);
+        $this->assertInternalType('integer', $newId);
+        $this->assertEquals($uid, $newId);
+    }
+
+    public function testGetIdFromUserParamUsername()
+    {
+        $uid   = $this->addUser('someusername');
+        $newId = $this->us->getIdFromUser('someusername');
+        $this->assertInternalType('integer', $newId);
+        $this->assertEquals($uid, $newId);
+    }
+
 
 
     /**