minor code clean-ups

diff --git a/languages/en.php b/languages/en.php
index e6c66b27faf464eab43eb17e8f381dea4023e8fa..07ff029052f9c3c67f742f2e33d3846f6ba969c3 100644 (file)
--- a/languages/en.php
+++ b/languages/en.php
@@ -9,6 +9,7 @@ $english = array(
        'simplepie:num_items' => 'Number of items',\r
        'simplepie:excerpt' => 'Include excerpt',\r
        'simplepie:post_date' => 'Include post date',\r
+       'simplepie:postedon' => 'Posted on',\r
 );\r
 \r
 add_translation("en", $english);\r

diff --git a/start.php b/start.php
index 538c5625c7d9cee47921fc0a67571665a3bcc75b..12acb74f9a1c07d30e2527ab88974919b72082b4 100644 (file)
--- a/start.php
+++ b/start.php
@@ -8,8 +8,7 @@
 \r
 function simplepie_init() {\r
        add_widget_type('feed_reader', elgg_echo('simplepie:widget'), elgg_echo('simplepie:description'));\r
-\r
-       extend_view('css','feed_reader/css');\r
+       elgg_extend_view('css', 'feed_reader/css');\r
 }\r
 \r
 register_elgg_event_handler('plugins_boot', 'system', 'simplepie_init');\r

diff --git a/views/default/widgets/feed_reader/edit.php b/views/default/widgets/feed_reader/edit.php
index 77355bfa4cc8028ef3ae9aca8e9ca6b0790284b4..a721f0e8a89201fe13e043efc3af81479d4b91dd 100644 (file)
--- a/views/default/widgets/feed_reader/edit.php
+++ b/views/default/widgets/feed_reader/edit.php
@@ -41,7 +41,10 @@
 
 <p>
 <?php 
-echo elgg_view('input/hidden', array('internalname' => 'params[excerpt]', 'js' => 'id="params[excerpt]"', 'value' => $excerpt ));
+// used a hidden input field so that something is always sent unlike a checkbox
+echo elgg_view('input/hidden', array('internalname' => 'params[excerpt]', 
+                                                                       'js' => 'id="params[excerpt]"', 
+                                                                       'value' => $excerpt ));
 echo "<input class='input-checkboxes' type='checkbox' value='' name='excerptcheckbox' onclick=\"document.getElementById('params[excerpt]').value = 1 - document.getElementById('params[excerpt]').value;\" ";
 if ($excerpt) {
        echo "checked='yes'";
@@ -53,7 +56,9 @@ echo ' ' . elgg_echo('simplepie:excerpt');
 
 <p>
 <?php 
-echo elgg_view('input/hidden', array('internalname' => 'params[post_date]', 'js' => 'id="params[post_date]"', 'value' => $post_date ));
+echo elgg_view('input/hidden', array('internalname' => 'params[post_date]', 
+                                                                       'js' => 'id="params[post_date]"', 
+                                                                       'value' => $post_date ));
 echo "<input class='input-checkboxes' type='checkbox' value='' name='post_datecheckbox' onclick=\"document.getElementById('params[post_date]').value = 1 - document.getElementById('params[post_date]').value;\" ";
 if ($post_date) {
        echo "checked='yes'";

diff --git a/views/default/widgets/feed_reader/view.php b/views/default/widgets/feed_reader/view.php
index a8d589f981f3b4f641d3d643bbf73ba27832f161..329b2fb981664e989b8220e514b8e1c218a6a23a 100644 (file)
--- a/views/default/widgets/feed_reader/view.php
+++ b/views/default/widgets/feed_reader/view.php
@@ -51,12 +51,19 @@ if ($feed_url) {
                </div>
 <?php 
                if ($excerpt) {
-                       echo '<div class="simplepie_excerpt">' . strip_tags($item->get_description(true), $allow_tags) . '</div>';
+?>
+                       <div class="simplepie_excerpt">
+                               <?php echo strip_tags($item->get_description(true), $allow_tags); ?>
+                       </div>
+<?php
                }
 
                if ($post_date) {
 ?>
-               <div class="simplepie_date">Posted on <?php echo $item->get_date('j F Y | g:i a'); ?></div>
+               <div class="simplepie_date">
+                       <?php echo elgg_echo('simplepie:postedon'); ?> 
+                       <?php echo $item->get_date('j F Y | g:i a'); ?>
+               </div>
 <?php 
                } 
 ?>