(PA-5395) Use reusable static code analysis

This commit updates the static code analysis GitHub Actions workflow
from using a copy in this repository to a resuable copy in the Phoenix
team centralized GitHub Actions repository.

In addition, this removes the commits Rake task as it is no longer used
in the reusable version of this workflow.

diff --git a/.github/workflows/static_code_analysis.yaml b/.github/workflows/static_code_analysis.yaml
index 575cde7157d242c656c9e5a24eb91b6ea8e5f2c8..62438daee5893fedccd8aef5badc22e38f43290e 100644 (file)
--- a/.github/workflows/static_code_analysis.yaml
+++ b/.github/workflows/static_code_analysis.yaml
@@ -6,44 +6,8 @@ on:
     branches: [ main ]
   pull_request:
     branches: [ main ]
+  workflow_dispatch:
 
 jobs:
   static_code_analysis:
-    name: Run checks
-
-    env:
-      ruby_version: 2.6
-      extra_checks: check:symlinks check:git_ignore check:dot_underscore check:test_file
-
-    runs-on: 'ubuntu-20.04'
-    steps:
-      - name: Checkout current PR code
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Install ruby version ${{ env.ruby_version }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ env.ruby_version }}
-
-      - name: Prepare testing environment with bundler
-        run: |
-          git config --global core.longpaths true
-          bundle config set --local without 'release'
-          bundle update --jobs 4 --retry 3
-
-      - name: Run commits check
-        run: bundle exec rake commits
-
-      - name: Run rubocop check
-        run: bundle exec rake ${{ env.extra_checks }} rubocop
-
-      - name: Run syntax check
-        run: bundle exec rake ${{ env.extra_checks }} syntax syntax:hiera syntax:manifests syntax:templates
-
-      - name: Run lint check
-        run: bundle exec rake ${{ env.extra_checks }} lint
-
-      - name: Run metadata_lint check
-        run: bundle exec rake ${{ env.extra_checks }} metadata_lint
+    uses: "puppetlabs/phoenix-github-actions/.github/workflows/static_code_analysis.yaml@main"

diff --git a/rakelib/commits.rake b/rakelib/commits.rake
deleted file mode 100644 (file)
index 7cee9fa..0000000
--- a/rakelib/commits.rake
+++ /dev/null
@@ -1,25 +0,0 @@
-desc "verify that commit summaries are properly formatted"
-task(:commits) do
-  # This rake task looks at the summary from every commit from this branch not
-  # in the branch targeted for a PR.
-  commit_range = 'HEAD^..HEAD'
-  puts "Checking commits #{commit_range}"
-  %x{git log --no-merges --pretty=%s #{commit_range}}.each_line do |commit_summary|
-    # This regex tests for the currently supported commit summary tokens.
-    # The exception tries to explain it in more full.
-    if /^Release prep|\((maint|packaging|doc|docs|modules|pa-\d+)\)|revert/i.match(commit_summary).nil?
-      raise "\n\n\n\tPlease make sure that your commit summary (i.e. the first line of the commit message) starts with one of the following:\n"  \
-        "\t\t(PA-<digits>)\n" \
-        "\t\t(MODULES-<digits>)\n" \
-        "\t\t(docs)\n" \
-        "\t\t(docs)(DOCUMENT-<digits>)\n" \
-        "\t\t(packaging)\n"
-        "\t\t(maint)\n" \
-        "\t\tRelease prep v<tag>\n" \
-        "\n\tThis test for the commit summary is case-insensitive.\n\n\n"
-    else
-      puts "#{commit_summary}"
-    end
-    puts "...passed"
-  end
-end