Remove duplicate rake task and enable metadata.json linting

The :validate task is already provided by
puppetlabs_spec_helper/rake_tasks and would check files twice.

The metadata.json linting is just good form.

diff --git a/Gemfile b/Gemfile
index 82a5204276897c64798fadb3aa363802e0c637c9..9d38f35e7d90d9a863e76bfee9a53c350493aff5 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -17,6 +17,7 @@ group :development, :unit_tests do
   gem 'mocha',                   :require => false
   gem 'puppetlabs_spec_helper',  :require => false
   gem 'puppet-lint',             :require => false
+  gem 'metadata-json-lint',      :require => false
   gem 'pry',                     :require => false
   gem 'simplecov',               :require => false
 end

diff --git a/Rakefile b/Rakefile
index 4ed1327a3bef6a47456c46f723315caa6f55af9d..13ee3d9b79e1c4e66849b08645c101e5009750b2 100644 (file)
--- a/Rakefile
+++ b/Rakefile
@@ -4,15 +4,3 @@ require 'puppet-lint/tasks/puppet-lint'
 PuppetLint.configuration.send('disable_80chars')
 PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
 
-desc "Validate manifests, templates, and ruby files in lib."
-task :validate do
-  Dir['manifests/**/*.pp'].each do |manifest|
-    sh "puppet parser validate --noop #{manifest}"
-  end
-  Dir['lib/**/*.rb'].each do |lib_file|
-    sh "ruby -c #{lib_file}"
-  end
-  Dir['templates/**/*.erb'].each do |template|
-    sh "erb -P -x -T '-' #{template} | ruby -c"
-  end
-end