Fix :false to be default value

false is not a valid value; only :false is.

diff --git a/Gemfile b/Gemfile
index bfe64b186a6fe4cf56aec869ba119d2174b1607c..ee1eb6b25323b6c62ffa68fa26df372acc483154 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -16,6 +16,7 @@ group :development, :unit_tests do
   gem 'simplecov',               :require => false
   gem 'puppet_facts',            :require => false
   gem 'json',                    :require => false
+  gem 'pry',                     :require => false
 end
 
 group :system_tests do

diff --git a/lib/puppet/provider/vcsrepo/svn.rb b/lib/puppet/provider/vcsrepo/svn.rb
index ba77464a6b6fd86cdbe6072594ef7d6728c2a0a3..fccfaa5a3b198ba6ec3816165c241328f00f9d62 100644 (file)
--- a/lib/puppet/provider/vcsrepo/svn.rb
+++ b/lib/puppet/provider/vcsrepo/svn.rb
@@ -63,7 +63,7 @@ Puppet::Type.type(:vcsrepo).provide(:svn, :parent => Puppet::Provider::Vcsrepo)
       args.push('--config-dir', @resource.value(:configuration))
     end
 
-    if @resource.value(:trust_server_cert)
+    if @resource.value(:trust_server_cert) != :false
       args.push('--trust-server-cert')
     end
 

diff --git a/lib/puppet/type/vcsrepo.rb b/lib/puppet/type/vcsrepo.rb
index da1dcde0d1506f219383a92a34263adebf5a7250..290bdad74fdbd29c7c087d985d4b104e5c43b4b7 100644 (file)
--- a/lib/puppet/type/vcsrepo.rb
+++ b/lib/puppet/type/vcsrepo.rb
@@ -231,7 +231,7 @@ Puppet::Type.newtype(:vcsrepo) do
   newparam :trust_server_cert do
     desc "Trust server certificate"
     newvalues(:true, :false)
-    defaultto false
+    defaultto :false
   end
 
   autorequire(:package) do

diff --git a/spec/unit/puppet/provider/vcsrepo/svn_spec.rb b/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
index 25951bd88edf70abe75e526a016dfce05e2ff7bd..6a37c205b78eff78a6dff7a79588700a4dbc3959 100644 (file)
--- a/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
+++ b/spec/unit/puppet/provider/vcsrepo/svn_spec.rb
@@ -65,9 +65,17 @@ describe Puppet::Type.type(:vcsrepo).provider(:svn) do
     end
     
     context "with trust_server_cert" do
+      it "should execute 'svn checkout' without a trust-server-cert" do
+        resource[:source] = 'exists'
+        resource[:trust_server_cert] = :false
+        provider.expects(:svn).with('--non-interactive', 'checkout',
+          resource.value(:source),
+          resource.value(:path))
+        provider.create
+      end
       it "should execute 'svn checkout' with a trust-server-cert" do
         resource[:source] = 'exists'
-        resource[:trust_server_cert] = true
+        resource[:trust_server_cert] = :true
         provider.expects(:svn).with('--non-interactive', '--trust-server-cert', 'checkout',
           resource.value(:source),
           resource.value(:path))