test getObjectUsers() and fix a bug found by the tests

git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@484 b3834d28-1941-0410-a4f8-b48e95affb8f

diff --git a/src/SemanticScuttle/Service/User.php b/src/SemanticScuttle/Service/User.php
index 3f07242076c718b15e71dc48afbfb3f42ad394b2..5affa0bb6cb9bf3403180e33a7e787309327b58d 100644 (file)
--- a/src/SemanticScuttle/Service/User.php
+++ b/src/SemanticScuttle/Service/User.php
@@ -155,6 +155,7 @@ class SemanticScuttle_Service_User extends SemanticScuttle_DbService
             return false;
         }
 
+        $users = array();
         while ($row = & $this->db->sql_fetchrow($dbresult)) {
             $users[] = new SemanticScuttle_Model_User(
                 $row[$this->getFieldName('primary')],

diff --git a/tests/UserTest.php b/tests/UserTest.php
index 513011badd7d1b36a8d5d693c91634306f9c5a27..a68d7dc77e58e1efa842850159973248cd0b5b02 100644 (file)
--- a/tests/UserTest.php
+++ b/tests/UserTest.php
@@ -53,6 +53,7 @@ class UserTest extends TestBase
     protected function setUp()
     {
         $this->us = SemanticScuttle_Service_Factory::get('User');
+        $this->us->deleteAll();
     }
 
 
@@ -118,6 +119,51 @@ class UserTest extends TestBase
         );
     }
 
+
+
+    /**
+     * Check if getObjectUsers() without any user works
+     *
+     * @return void
+     */
+    public function testGetObjectUsersNone()
+    {
+        $users = $this->us->getObjectUsers();
+        $this->assertEquals(0, count($users));
+    }
+
+
+
+    /**
+     * Check if getObjectUsers() with a single user works
+     *
+     * @return void
+     */
+    public function testGetObjectUsersSingle()
+    {
+        $uid = $this->addUser();
+        $users = $this->us->getObjectUsers();
+        $this->assertEquals(1, count($users));
+        $this->assertType('SemanticScuttle_Model_User', reset($users));
+    }
+
+
+
+    /**
+     * Check if getObjectUsers() with a several users works
+     *
+     * @return void
+     */
+    public function testGetObjectUsersMultiple()
+    {
+        $uid = $this->addUser();
+        $uid2 = $this->addUser();
+        $uid3 = $this->addUser();
+        $users = $this->us->getObjectUsers();
+        $this->assertEquals(3, count($users));
+        $this->assertType('SemanticScuttle_Model_User', reset($users));
+    }
+
 }