Update redhat tftp file owner.

This update address file owner to nobody by default for RHEL family.

diff --git a/.fixtures.yml b/.fixtures.yml
index a38b2cb785d12c55a1ffa56a4c542373e6f16fab..970cd59ad7e3af68332a43eef5dec6c9bf3edaae 100644 (file)
--- a/.fixtures.yml
+++ b/.fixtures.yml
@@ -1,5 +1,5 @@
 fixtures:
   repositories:
-    "inetd": "git://github.com/puppetlabs/puppetlabs-inetd.git"
+    "xinetd": "git://github.com/puppetlabs/puppetlabs-xinetd.git"
   symlinks:
     "tftp": "#{source_dir}"

diff --git a/manifests/file.pp b/manifests/file.pp
index 3628188fca0097c02e323793c2c6da0c4451f629..48a5fabf5d15afbd63f78ecb8acd05839b27b4cb 100644 (file)
--- a/manifests/file.pp
+++ b/manifests/file.pp
@@ -29,8 +29,8 @@
 #
 define tftp::file (
   $ensure       = file,
-  $owner        = 'tftp',
-  $group        = 'tftp',
+  $owner        = undef,
+  $group        = undef,
   $mode         = '0644',
   $recurse      = false,
   $purge        = undef,
@@ -40,6 +40,19 @@ define tftp::file (
   $source       = undef
 ) {
   include 'tftp'
+  include 'tftp::params'
+
+  if $owner {
+    $tftp_owner = $owner
+  } else {
+    $tftp_owner = $tftp::params::username
+  }
+
+  if $group {
+    $tftp_group = $group
+  } else {
+    $tftp_group = $tftp::params::username
+  }
 
   if $source {
     $source_real = $source
@@ -54,8 +67,8 @@ define tftp::file (
 
   file { "${tftp::directory}/${name}":
     ensure       => $ensure,
-    owner        => $owner,
-    group        => $group,
+    owner        => $tftp_owner,
+    group        => $tftp_group,
     mode         => $mode,
     recurse      => $recurse,
     purge        => $purge,

diff --git a/spec/defines/tftp_file_spec.rb b/spec/defines/tftp_file_spec.rb
index e24f0f32dcb0ef972549a123f2f10d5bf00fbc91..38f34a64fa4bfcbb031c4abc2b7ee32feea93d71 100644 (file)
--- a/spec/defines/tftp_file_spec.rb
+++ b/spec/defines/tftp_file_spec.rb
@@ -38,6 +38,23 @@ describe 'tftp::file' do
     }
   end
 
+  describe 'when deploying on redhat' do
+    let(:facts) { { :operatingsystem => 'RedHat',
+                    :osfamily        => 'redhat',
+                    :path            => '/usr/local/bin:/usr/bin:/bin', } }
+
+    it {
+      should include_class('tftp')
+      should contain_file('/var/lib/tftpboot/sample').with({
+        'ensure'  => 'file',
+        'owner'   => 'nobody',
+        'group'   => 'nobody',
+        'mode'    => '0644',
+        'recurse' => false,
+      })
+    }
+  end
+
   describe 'when deploying with parameters' do
     let(:params) { {:ensure => 'directory',
                     :owner  => 'root',