Bug fix: test username's length (max 25) when registering (preventing problem with...

git-svn-id: https://semanticscuttle.svn.sourceforge.net/svnroot/semanticscuttle/trunk@155 b3834d28-1941-0410-a4f8-b48e95affb8f

diff --git a/register.php b/register.php
index e60a686eadd31b97bcd172f2317aefc2a2d9aa50..b70d7245424f54d7ecb3209abe48980d1229408b 100644 (file)
--- a/register.php
+++ b/register.php
@@ -39,6 +39,10 @@ if (isset($_POST['submitted'])) {
     // Check if username already exists
     } elseif ($userservice->getUserByUsername($posteduser)) {
         $tplVars['error'] = T_('This username already exists, please make another choice.');
+        
+    // Check if username is valid (length, authorized characters)
+    } elseif (!$userservice->isValidUsername($posteduser)) {
+        $tplVars['error'] = T_('This username is not valid (too long, forbidden characters...), please make another choice.');        
     
     // Check if e-mail address is valid
     } elseif (!$userservice->isValidEmail($_POST['email'])) {

diff --git a/services/userservice.php b/services/userservice.php
index ee62dbb0fadf8fbca1f4e45d4a1d4d7fa3f3fcc8..e50faaa8fa9ea1825fcdb8962ad6d8bb9ed0ffa9 100644 (file)
--- a/services/userservice.php
+++ b/services/userservice.php
@@ -388,6 +388,18 @@ class UserService {
                        return false;
                }
         }
+        
+        function isValidUsername($username) {
+               if (strlen($username) > 24) {
+                       // too long usernames are cut by database and may cause bugs when compared 
+                       return false;
+               } else {
+                       return true;
+               }
+               return true;
+        }        
+
+        
 
         function isValidEmail($email) {
                if (eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,6})$", $email)) {