Fully fix bug #3463481: use proper self URL, different page url

diff --git a/data/templates/default/rss.tpl.php b/data/templates/default/rss.tpl.php
index fd5bdbf34bc774f8428ff9ee2f7a0a3487e85691..4aba277c5a5603eacf6e26200926a5fc8b0cc81a 100644 (file)
--- a/data/templates/default/rss.tpl.php
+++ b/data/templates/default/rss.tpl.php
@@ -6,7 +6,7 @@ echo '<' . '?xml version="1.0" encoding="utf-8" ?' . ">\n";
 >
 <channel>
     <title><?php echo $feedtitle; ?></title>
-    <link><?php echo htmlspecialchars($feedlink); ?></link>
+    <link><?php echo htmlspecialchars($pagelink); ?></link>
     <atom:link rel="self" type="application/rss+xml" href="<?php echo htmlspecialchars($feedlink); ?>"/>
     <description><?php echo htmlspecialchars($feeddescription); ?></description>
     <pubDate><?php echo date('r'); ?></pubDate>

diff --git a/doc/ChangeLog b/doc/ChangeLog
index 67da85e1b5fee00f4d38d44c7c220a7803a3b090..d52787c56a3a6b3ce5cf6b71afa7419bbffd2aac 100644 (file)
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -13,6 +13,7 @@ ChangeLog for SemantiScuttle
 - Fix bug #3407728: Can't delete users from admin page
 - Fix bug #3431742: open_basedir problems with /etc/ config files
 - Fix bug #3436624: Wrong URL for Delicious API when importing
+- Fix bug #3463481: RSS feed show warnings in feedvalidator.org
 - Implement request #3403609: fr_CA translation update
 - Implement patch #3476011: PostgreSQL tables can not be initialized
   (Frédéric Fauberteau [triaxx])

diff --git a/www/rss.php b/www/rss.php
index 3628a2e5ba823a33ee4ad5025e7865d5966fdfef..1f8894447b4fb4b9040de3fc6754fbf01a2f49c5 100644 (file)
--- a/www/rss.php
+++ b/www/rss.php
@@ -124,7 +124,8 @@ if ($cat) {
 }
 
 $tplVars['feedtitle'] = filter($GLOBALS['sitename'] . (isset($pagetitle) ? $pagetitle : ''));
-$tplVars['feedlink'] = addProtocolToUrl(ROOT);
+$tplVars['pagelink'] = addProtocolToUrl(ROOT);
+$tplVars['feedlink'] = addProtocolToUrl(ROOT) . 'rss?sort=' . getSortOrder();
 $tplVars['feeddescription'] = sprintf(T_('Recent bookmarks posted to %s'), $GLOBALS['sitename']);
 
 $bookmarks = $bookmarkservice->getBookmarks(