From: Brett Profitt <brett.profitt@gmail.com>
Date: Wed, 4 Jan 2012 23:05:21 +0000 (-0800)
Subject: Fixes #3710. Returning false from update, <type> event no longer deletes entity.
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=24a369c78df14469097dd440bba3cee087a39e7b;p=lorea%2Felgg.git

Fixes #3710. Returning false from update, <type> event no longer deletes entity.
Returning false from create, <type> still deletes the entity because of the "return false to halt events" approach. This will be reviewed for #3784.
---

diff --git a/engine/lib/objects.php b/engine/lib/objects.php
index 63d0f5cef..f186c66cb 100644
--- a/engine/lib/objects.php
+++ b/engine/lib/objects.php
@@ -52,11 +52,8 @@ function create_object_entity($guid, $title, $description) {
 			if ($result != false) {
 				// Update succeeded, continue
 				$entity = get_entity($guid);
-				if (elgg_trigger_event('update', $entity->type, $entity)) {
-					return $guid;
-				} else {
-					$entity->delete();
-				}
+				elgg_trigger_event('update', $entity->type, $entity);
+				return $guid;
 			}
 		} else {
 			// Update failed, attempt an insert.