From: Jeff McCune <jeff@puppetlabs.com>
Date: Thu, 12 Jan 2012 03:15:04 +0000 (-0800)
Subject: Add additional domain name tests
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=501bcba719d636e851668ac208d1c623dfaaf931;p=puppet-stdlib.git

Add additional domain name tests

Without this patch some valid domain names are not covered in the spec
tests as Stig Sandbeck Mathisen <ssm@debian.org> points out.  This patch
adds spec tests for the domains "." and "x.com" which are both valid.
---

diff --git a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
index b419231..ccd3276 100644
--- a/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
+++ b/spec/unit/puppet/parser/functions/is_domain_name_spec.rb
@@ -16,6 +16,21 @@ describe "the is_domain_name function" do
     lambda { scope.function_is_domain_name([]) }.should( raise_error(Puppet::ParseError))
   end
 
+  it "should return true if a valid short domain name" do
+    result = scope.function_is_domain_name(["x.com"])
+    result.should(be_true)
+  end
+
+  it "should return true if the domain is ." do
+    result = scope.function_is_domain_name(["."])
+    result.should(be_true)
+  end
+
+  it "should return true if the domain is x.com." do
+    result = scope.function_is_domain_name(["x.com."])
+    result.should(be_true)
+  end
+
   it "should return true if a valid domain name" do
     result = scope.function_is_domain_name(["foo.bar.com"])
     result.should(be_true)