From: cash <cash.costello@gmail.com>
Date: Sat, 31 Dec 2011 15:18:01 +0000 (-0500)
Subject: Fixes #4256 reruns the forum topic upgrade by checking the 5 oldest topics
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=6dc5a90146595b78f5fd0d9b10b628a78ca2dac7;p=lorea%2Felgg.git

Fixes #4256 reruns the forum topic upgrade by checking the 5 oldest topics
---

diff --git a/mod/groups/upgrades/2011030101.php b/mod/groups/upgrades/2011030101.php
index 9ed5b321b..55edb1a16 100644
--- a/mod/groups/upgrades/2011030101.php
+++ b/mod/groups/upgrades/2011030101.php
@@ -9,6 +9,7 @@ $topics = elgg_get_entities(array(
 	'type' => 'object',
 	'subtype' => 'groupforumtopic',
 	'limit' => 5,
+	'order_by' => 'e.time_created asc',
 ));
 
 // if not topics, no upgrade required
@@ -31,6 +32,11 @@ foreach ($topics as $topic) {
  */
 function groups_2011030101($topic) {
 
+	// do not upgrade topics that have already been upgraded
+	if ($topic->description) {
+		return true;
+	}
+
 	$annotation = $topic->getAnnotations('group_topic_post', 1);
 	if (!$annotation) {
 		// no text for this forum post so we delete (probably caused by #2624)