From: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
Date: Sat, 30 Apr 2011 01:49:15 +0000 (+0100)
Subject: Moved to unless from if not to improve code clarity.  Changed
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=9d0e2447712dd3c01b59c723251eb8c02933e501;p=puppet-stdlib.git

Moved to unless from if not to improve code clarity.  Changed
wording of few error messages.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
---

diff --git a/member.rb b/member.rb
index 73030d7..bb43a37 100644
--- a/member.rb
+++ b/member.rb
@@ -15,14 +15,14 @@ module Puppet::Parser::Functions
 
     array = arguments[0]
 
-    if not array.is_a?(Array)
-      raise(Puppet::ParseError, 'member(): Requires an array to work with')
+    unless array.is_a?(Array)
+      raise(Puppet::ParseError, 'member(): Requires array to work with')
     end
 
     item = arguments[1]
 
     raise(Puppet::ParseError, 'member(): You must provide item ' +
-      'to search for within given array') if item.empty?
+      'to search for within array given') if item.empty?
 
     result = array.include?(item)