From: Steve Clay <steve@mrclay.org>
Date: Sun, 23 Jun 2013 00:19:53 +0000 (-0400)
Subject: Fixes #5673: Properly check simplecache views list if cache file missing
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=c9d1dd21d3dcf7353570d555c21a2b6ca7ecdd00;p=lorea%2Felgg.git

Fixes #5673: Properly check simplecache views list if cache file missing
---

diff --git a/engine/handlers/cache_handler.php b/engine/handlers/cache_handler.php
index 9848d3531..36fc665bb 100644
--- a/engine/handlers/cache_handler.php
+++ b/engine/handlers/cache_handler.php
@@ -88,20 +88,18 @@ header("ETag: \"$etag\"");
 $filename = $dataroot . 'views_simplecache/' . md5($viewtype . $view);
 
 if (file_exists($filename)) {
-	$contents = file_get_contents($filename);
+	readfile($filename);
 } else {
 	// someone trying to access a non-cached file or a race condition with cache flushing
 	mysql_close($mysql_dblink);
 	require_once(dirname(dirname(__FILE__)) . "/start.php");
 
 	global $CONFIG;
-	if (!isset($CONFIG->views->simplecache[$view])) {
+	if (!in_array($view, $CONFIG->views->simplecache)) {
 		header("HTTP/1.1 404 Not Found");
 		exit;
 	}
 
 	elgg_set_viewtype($viewtype);
-	$contents = elgg_view($view);
+	echo elgg_view($view);
 }
-
-echo $contents;