From: Cash Costello <cash.costello@gmail.com>
Date: Sat, 24 Dec 2011 00:26:08 +0000 (-0500)
Subject: Fixes #682 not deleting metadata when update, metadata event handlers return false
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=e3100d350c27804f80de3321b00be9dfc23c6d2a;p=lorea%2Felgg.git

Fixes #682 not deleting metadata when update, metadata event handlers return false
---

diff --git a/engine/lib/metadata.php b/engine/lib/metadata.php
index 050e69526..4908b3e88 100644
--- a/engine/lib/metadata.php
+++ b/engine/lib/metadata.php
@@ -216,12 +216,11 @@ function update_metadata($id, $name, $value, $value_type, $owner_guid, $access_i
 
 	$result = update_data($query);
 	if ($result !== false) {
+		// @todo this event tells you the metadata has been updated, but does not
+		// let you do anything about it. What is needed is a plugin hook before
+		// the update that passes old and new values.
 		$obj = elgg_get_metadata_from_id($id);
-		if (elgg_trigger_event('update', 'metadata', $obj)) {
-			return true;
-		} else {
-			elgg_delete_metadata_by_id($id);
-		}
+		elgg_trigger_event('update', 'metadata', $obj);
 	}
 
 	return $result;