From: Silvio Rhatto <rhatto@riseup.net>
Date: Sat, 30 Dec 2017 02:25:24 +0000 (-0200)
Subject: Escaping dotted notation for sshkey lookup
X-Git-Url: https://gitweb.fluxo.info/?a=commitdiff_plain;h=ef69b77ccada9e983cd8e79ed92c90a84a8ff9fe;p=puppet-backup.git

Escaping dotted notation for sshkey lookup
---

diff --git a/manifests/user.pp b/manifests/user.pp
index eb303cb..3ada103 100644
--- a/manifests/user.pp
+++ b/manifests/user.pp
@@ -1,14 +1,12 @@
 # Inspired by backupninja::sandbox
+#
+# Escaping dotted notation for sshkey lookup, see
+# https://puppet.com/docs/puppet/5.3/hiera_automatic.html#hiera-dotted-notation
 define backup::user(
   $ensure         = present,
   $hosting_domain = $::domain,
-  $sshkey         = '',
+  $sshkey         = hiera("'ssh_authorized_key::${name}.${hosting_domain}'"),
 ) {
-  $real_sshkey = $sshkey ? {
-    ''      => hiera("ssh_authorized_key::${name}.${hosting_domain}"),
-    default => $sshkey,
-  }
-
   user::manage { $name:
     ensure   => $ensure,
     password => '*',
@@ -16,6 +14,6 @@ define backup::user(
     gid      => 'backupninjas',
     shell    => '/bin/bash',
     homedir  => "${::backup::params::backupdir_remote}/${name}.${hosting_domain}",
-    sshkey   => $real_sshkey,
+    sshkey   => $sshkey,
   }
 }